[v8-dev] [turbofan] Fix overzealous reserving of lazy deopt space. (issue 1186353003 by [email protected])

Tue, 16 Jun 2015 07:40:43 -0700 

Reviewers: jarin,

Description:
[turbofan] Fix overzealous reserving of lazy deopt space.

This fixes CodeGenerator::EnsureSpaceForLazyDeopt to no longer be
treated as a lazy deopt site in itself. Calls mark themselves as lazy
bailout sites in CodeGenerator::RecordCallPosition, which suffices.

[email protected]

Please review this at https://codereview.chromium.org/1186353003/

Base URL: https://chromium.googlesource.com/v8/v8.git@master

Affected files (+0, -8 lines):
  M src/compiler/arm/code-generator-arm.cc
  M src/compiler/arm64/code-generator-arm64.cc
  M src/compiler/ia32/code-generator-ia32.cc
  M src/compiler/mips/code-generator-mips.cc
  M src/compiler/mips64/code-generator-mips64.cc
  M src/compiler/ppc/code-generator-ppc.cc
  M src/compiler/x64/code-generator-x64.cc
  M src/compiler/x87/code-generator-x87.cc


Index: src/compiler/arm/code-generator-arm.cc
diff --git a/src/compiler/arm/code-generator-arm.cc b/src/compiler/arm/code-generator-arm.cc index a264308496e6bcdcb7cc4304b42a44a23999017e..a4ab884f8f203697026127fbec31449abb66106c 100644 
--- a/src/compiler/arm/code-generator-arm.cc
+++ b/src/compiler/arm/code-generator-arm.cc
@@ -1217,7 +1217,6 @@ void CodeGenerator::EnsureSpaceForLazyDeopt() {
       }
     }
   }
-  MarkLazyDeoptSite();
 }

 #undef __
Index: src/compiler/arm64/code-generator-arm64.cc
diff --git a/src/compiler/arm64/code-generator-arm64.cc b/src/compiler/arm64/code-generator-arm64.cc index 831627dde5cfed8553a8f036e2b53008a78a3bc1..736d5638d8edddb63ade5e5c4bf5c1e2d67675c4 100644 
--- a/src/compiler/arm64/code-generator-arm64.cc
+++ b/src/compiler/arm64/code-generator-arm64.cc
@@ -1329,7 +1329,6 @@ void CodeGenerator::EnsureSpaceForLazyDeopt() {
       }
     }
   }
-  MarkLazyDeoptSite();
 }

 #undef __
Index: src/compiler/ia32/code-generator-ia32.cc
diff --git a/src/compiler/ia32/code-generator-ia32.cc b/src/compiler/ia32/code-generator-ia32.cc index 53b4ebe7cecff7819022b4335a017525559b6121..de3bac15e13539d1033d681a2d652b9a4f44cd27 100644 
--- a/src/compiler/ia32/code-generator-ia32.cc
+++ b/src/compiler/ia32/code-generator-ia32.cc
@@ -1511,7 +1511,6 @@ void CodeGenerator::EnsureSpaceForLazyDeopt() {
       __ Nop(padding_size);
     }
   }
-  MarkLazyDeoptSite();
 }

 #undef __
Index: src/compiler/mips/code-generator-mips.cc
diff --git a/src/compiler/mips/code-generator-mips.cc b/src/compiler/mips/code-generator-mips.cc index 872eeb454a58f5816af49fa4fe32a1271563e1c2..3afb86af45556328c1af7f805c3cf578e4eb216a 100644 
--- a/src/compiler/mips/code-generator-mips.cc
+++ b/src/compiler/mips/code-generator-mips.cc
@@ -1341,7 +1341,6 @@ void CodeGenerator::EnsureSpaceForLazyDeopt() {
       }
     }
   }
-  MarkLazyDeoptSite();
 }

 #undef __
Index: src/compiler/mips64/code-generator-mips64.cc
diff --git a/src/compiler/mips64/code-generator-mips64.cc b/src/compiler/mips64/code-generator-mips64.cc index 5296ea82f7af01cb7ff304df99db54fba9017ab9..998a4f3f894bdb08d4396fe4357fc9f6e17d2b8e 100644 
--- a/src/compiler/mips64/code-generator-mips64.cc
+++ b/src/compiler/mips64/code-generator-mips64.cc
@@ -1414,7 +1414,6 @@ void CodeGenerator::EnsureSpaceForLazyDeopt() {
       }
     }
   }
-  MarkLazyDeoptSite();
 }

 #undef __
Index: src/compiler/ppc/code-generator-ppc.cc
diff --git a/src/compiler/ppc/code-generator-ppc.cc b/src/compiler/ppc/code-generator-ppc.cc index 936b1e038a92ebc34f486c3f1d90aa4605b9cf43..63ebfc89804c32ed48341cb004cd950e00b3f733 100644 
--- a/src/compiler/ppc/code-generator-ppc.cc
+++ b/src/compiler/ppc/code-generator-ppc.cc
@@ -1555,7 +1555,6 @@ void CodeGenerator::EnsureSpaceForLazyDeopt() {
       }
     }
   }
-  MarkLazyDeoptSite();
 }

 #undef __
Index: src/compiler/x64/code-generator-x64.cc
diff --git a/src/compiler/x64/code-generator-x64.cc b/src/compiler/x64/code-generator-x64.cc index 13e482d3c1e78df071425e2580e48e5b4d89613e..5f55b33f8385b1cebb7f72931546110bed6306c4 100644 
--- a/src/compiler/x64/code-generator-x64.cc
+++ b/src/compiler/x64/code-generator-x64.cc
@@ -1712,7 +1712,6 @@ void CodeGenerator::EnsureSpaceForLazyDeopt() {
       __ Nop(padding_size);
     }
   }
-  MarkLazyDeoptSite();
 }

 #undef __
Index: src/compiler/x87/code-generator-x87.cc
diff --git a/src/compiler/x87/code-generator-x87.cc b/src/compiler/x87/code-generator-x87.cc index a1ce22fc012422283d88db751c4cd5040ccc7b99..87d4e3ddfbac18150f5433e47be01b6b0a9ef18f 100644 
--- a/src/compiler/x87/code-generator-x87.cc
+++ b/src/compiler/x87/code-generator-x87.cc
@@ -1840,7 +1840,6 @@ void CodeGenerator::EnsureSpaceForLazyDeopt() {
       __ Nop(padding_size);
     }
   }
-  MarkLazyDeoptSite();
 }

 #undef __


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group. 
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to