https://codereview.chromium.org/1189743003/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1189743003/diff/1/src/parser.cc#newcode4227
src/parser.cc:4227: descriptor.mode = VAR;
Shouldn't this be LET?
https://codereview.chromium.org/1189743003/diff/1/src/scopes.h
File src/scopes.h (right):
https://codereview.chromium.org/1189743003/diff/1/src/scopes.h#newcode377
src/scopes.h:377: Expression* pattern;
Can we not abuse the scope abstraction to pass around parts of the AST?
It should be possible to get this information to the Build function in
parser.cc without piggybacking on the scope. It doesn't belong there.
https://codereview.chromium.org/1189743003/diff/1/test/mjsunit/harmony/destructuring.js
File test/mjsunit/harmony/destructuring.js (right):
https://codereview.chromium.org/1189743003/diff/1/test/mjsunit/harmony/destructuring.js#newcode692
test/mjsunit/harmony/destructuring.js:692: (function TestParameters() {
Can we have a few more tests? In particular, including arrow patterns
and nested patterns?
Also, checks that "function({x}) { var x; }' etc is a syntax error.
https://codereview.chromium.org/1189743003/diff/1/test/mjsunit/harmony/destructuring.js#newcode705
test/mjsunit/harmony/destructuring.js:705: var h = {a, b} => a - b;
AFAICT this is not legal ES6 syntax, see the grammar in
https://people.mozilla.org/~jorendorff/es6-draft.html#sec-arrow-function-definitions
https://codereview.chromium.org/1189743003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
