LGTM
I like giving scratch registers names.
In a separate change:
Consider porting some of the optimizations (interleaved bit compare and
incrementing counter before second character load) to the ia32 version.
CheckEitherSmi could be useful on ia32.
Consider having a BothFlatAsciiString as the code for this check is
duplicated.
It could be on either the macro assembler or the StringStubBase (currently
only
on ia32).
http://codereview.chromium.org/545108/diff/1/3
File src/x64/codegen-x64.cc (right):
http://codereview.chromium.org/545108/diff/1/3#newcode8274
src/x64/codegen-x64.cc:8274: __ Move(rax, Smi::FromInt(0));
0 -> EQUAL.
http://codereview.chromium.org/545108
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
