LGTM
http://codereview.chromium.org/553009/diff/1/2 File test/cctest/test-debug.cc (right): http://codereview.chromium.org/553009/diff/1/2#newcode2166 test/cctest/test-debug.cc:2166: int Utf16ToAscii(const uint16_t* input_buffer, Just the function definition to the top of the file. http://codereview.chromium.org/553009/diff/1/2#newcode2170 test/cctest/test-debug.cc:2170: bool GetEvaluateStringResult(char *message, char* buffer, int buffer_size); Move the function definition up here. http://codereview.chromium.org/553009/diff/1/2#newcode2190 test/cctest/test-debug.cc:2190: static void DebugProcessDebugMessagesHanlder( Hanlder -> Handler http://codereview.chromium.org/553009/diff/1/2#newcode2200 test/cctest/test-debug.cc:2200: % DebugProcessDebugMessagesData::kArraySize; Please move this logic into DebugProcessDebugMessagesData, e.g. method current() which returns a EvaluateResult*. http://codereview.chromium.org/553009/diff/1/2#newcode2206 test/cctest/test-debug.cc:2206: process_debug_messages_data.counter++; Please move this logic into DebugProcessDebugMessagesData, e.g. method next(). This method can also have a flag for whether the counter has wrapped, and that value can be checked in the test. http://codereview.chromium.org/553009/diff/1/2#newcode2210 test/cctest/test-debug.cc:2210: int AsciiToUtf16(const char* input_buffer, uint16_t* output_buffer); Just the function definition to the top of the file. http://codereview.chromium.org/553009/diff/1/2#newcode2225 test/cctest/test-debug.cc:2225: v8::Script::Compile(v8::String::New("void(0)")); I don't think the void0_script is used. http://codereview.chromium.org/553009
-- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
