LGTM, only nits.
https://codereview.chromium.org/1192553002/diff/1/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):
https://codereview.chromium.org/1192553002/diff/1/src/compiler/pipeline.cc#newcode288
src/compiler/pipeline.cc:288: // TODO(dcarney): make this into a
ZoneObject.
nit: TODO no longer applies, let's drop it.
https://codereview.chromium.org/1192553002/diff/1/src/compiler/typer.h
File src/compiler/typer.h (right):
https://codereview.chromium.org/1192553002/diff/1/src/compiler/typer.h#newcode24
src/compiler/typer.h:24: // TODO(bmeurer,jarin): Remove this once we
have a notion of "roots" on Graph.
nit: Either move the TODO one line lower or drop it completely.
https://codereview.chromium.org/1192553002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
