Refactored formal parameter parsing to better encapsulate state and separate
concerns.
Will now address other comments.
https://codereview.chromium.org/1189743003/diff/1/src/scopes.h
File src/scopes.h (right):
https://codereview.chromium.org/1189743003/diff/1/src/scopes.h#newcode377
src/scopes.h:377: Expression* pattern;
On 2015/06/16 17:02:13, rossberg wrote:
Can we not abuse the scope abstraction to pass around parts of the
AST? It
should be possible to get this information to the Build function in
parser.cc
without piggybacking on the scope. It doesn't belong there.
Good point. Addressed.
https://codereview.chromium.org/1189743003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
