Reviewers: Jakob,
Message:
Restores SortNumbers perf degrade
Description:
Make sure to flatten names before lookup. Lookup using cons strings is
really
slow.
BUG=chromium:495949, v8:4137
LOG=n
Please review this at https://codereview.chromium.org/1177043009/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+5, -5 lines):
M src/api.cc
M src/lookup.h
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index
8e6c554f1dddab89b225a483f841b2d66a719e34..560dc34b3004860c59c24f2c60e10c0bef7ce342
100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -3658,9 +3658,6 @@ i::MaybeHandle<i::Object> DeleteObjectProperty(
name = i::Handle<i::String>::cast(converted);
}
- if (name->IsString()) {
- name = i::String::Flatten(i::Handle<i::String>::cast(name));
- }
return i::JSReceiver::DeleteProperty(receiver, name, language_mode);
}
Index: src/lookup.h
diff --git a/src/lookup.h b/src/lookup.h
index
c2b98070c04c52b2b9cdcd913b971354cabe7b10..f856f50818223a926c67560f6e4b6edde2b80664
100644
--- a/src/lookup.h
+++ b/src/lookup.h
@@ -52,7 +52,7 @@ class LookupIterator final BASE_EMBEDDED {
interceptor_state_(InterceptorState::kUninitialized),
property_details_(PropertyDetails::Empty()),
isolate_(name->GetIsolate()),
- name_(name),
+ name_(String::Flatten(name)),
// kMaxUInt32 isn't a valid index.
index_(kMaxUInt32),
receiver_(receiver),
@@ -76,7 +76,7 @@ class LookupIterator final BASE_EMBEDDED {
interceptor_state_(InterceptorState::kUninitialized),
property_details_(PropertyDetails::Empty()),
isolate_(name->GetIsolate()),
- name_(name),
+ name_(String::Flatten(name)),
// kMaxUInt32 isn't a valid index.
index_(kMaxUInt32),
receiver_(receiver),
@@ -135,6 +135,7 @@ class LookupIterator final BASE_EMBEDDED {
static LookupIterator PropertyOrElement(
Isolate* isolate, Handle<Object> receiver, Handle<Name> name,
Configuration configuration = DEFAULT) {
+ name = String::Flatten(name);
uint32_t index;
LookupIterator it =
name->AsArrayIndex(&index)
@@ -147,6 +148,7 @@ class LookupIterator final BASE_EMBEDDED {
static LookupIterator PropertyOrElement(
Isolate* isolate, Handle<Object> receiver, Handle<Name> name,
Handle<JSReceiver> holder, Configuration configuration = DEFAULT) {
+ name = String::Flatten(name);
uint32_t index;
LookupIterator it =
name->AsArrayIndex(&index)
@@ -155,6 +157,7 @@ class LookupIterator final BASE_EMBEDDED {
it.name_ = name;
return it;
}
+
Isolate* isolate() const { return isolate_; }
State state() const { return state_; }
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
