Reviewers: Erik Corry,

Description:
Fix issue 571: display descriptive names for code objects from snapshot.

As this is only needed for internal profiling (not for DevTools),
the following approach had been chosen:

 - during snapshot creation, positions of serialized objects inside
   a snapshot are logged;

 - then during V8 initialization, positions of deserealized objects
   are logged;

 - those positions are used for retrieving code objects names from
   snapshot creation log, which needs to be supplied to tick processor
   script.

Positions logging is controlled with the new flag: --log_snapshot_positions.
This flag is turned off by default, and this adds no startup penalty.

To plug this fix to Golem, the following actions are needed:

 - logs created using 'mksnapshot' need to be stored along with VM images;

 - tick processor script needs to be run with '--snapshot-log=...' cmdline
   argument.

BUG=571

Please review this at http://codereview.chromium.org/551062

Affected files:
  M src/SConscript
  M src/flag-definitions.h
  M src/log.h
  M src/log.cc
  M src/mksnapshot.cc
  M src/serialize.h
  M src/serialize.cc
  M src/snapshot-common.cc
  M tools/profile.js
  M tools/tickprocessor-driver.js
  M tools/tickprocessor.js


-- 
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to