Reviewers: jochen,
Message:
PTAL
Description:
Dampen the old generation allocation limit only after the initial old
generation
size was configured.
Otherwise, dampening interferes with initial size configuration and causes
GC
too early.
BUG=501703
LOG=NO
Please review this at https://codereview.chromium.org/1183633005/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -1 lines):
M src/heap/heap.cc
Index: src/heap/heap.cc
diff --git a/src/heap/heap.cc b/src/heap/heap.cc
index
764d1003e9bfbf8bb25f9c8c31fff90fe5616143..78618798dde37220297a6953a21f0fdb1a8c1646
100644
--- a/src/heap/heap.cc
+++ b/src/heap/heap.cc
@@ -1296,7 +1296,8 @@ bool Heap::PerformGarbageCollection(
amount_of_external_allocated_memory_at_last_global_gc_ =
amount_of_external_allocated_memory_;
SetOldGenerationAllocationLimit(old_gen_size, gc_speed, mutator_speed);
- } else if (HasLowYoungGenerationAllocationRate()) {
+ } else if (HasLowYoungGenerationAllocationRate() &&
+ old_generation_size_configured_) {
DampenOldGenerationAllocationLimit(old_gen_size, gc_speed,
mutator_speed);
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
