Reviewers: fschneider,

Message:
When performing the inlined comparisons before calling the ToBoolean stub on
ia32 and x64, there was an extra value on the stack that needed to be discarded
in the case the value was needed in the accumulator register and not on the
stack.

Solution is to delay pushing the extra copy of the value until after the inlined comparisons (but only for expression contexts where it might be needed in the
accumulator).

Description:
Fix a bug in the short-circuit logical operations in the toplevel
code generator.


Please review this at http://codereview.chromium.org/542105

SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/

Affected files:
  M     src/ia32/fast-codegen-ia32.cc
  M     src/x64/fast-codegen-x64.cc
  M     src/x64/virtual-frame-x64.h


-- 
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to