Reviewers: Michael Achenbach,
Description:
Fixes possible race condition in retrieval of latest rolled version
[email protected]
BUG=
NOTRY=true
Please review this at https://codereview.chromium.org/1186393007/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+6, -0 lines):
M tools/release/auto_roll.py
M tools/release/test_scripts.py
Index: tools/release/auto_roll.py
diff --git a/tools/release/auto_roll.py b/tools/release/auto_roll.py
index
f7692cf6f9775681a9afdb6c13d82c60bb874044..72fdbc55dd8753f8a8ef254ab825ce9346a0a0a8
100755
--- a/tools/release/auto_roll.py
+++ b/tools/release/auto_roll.py
@@ -48,6 +48,10 @@ class DetectLastRoll(Step):
max_age=self._options.max_age * DAY_IN_SECONDS)
assert revisions, "Didn't find any recent release."
+ # Update Chromium checkout before DEPS check to fix possible
race-condition
+ cwd = self._options.chromium
+ self.GitPull(cwd=cwd)
+
# Interpret the DEPS file to retrieve the v8 revision.
# TODO(machenbach): This should be part or the roll-deps api of
# depot_tools.
Index: tools/release/test_scripts.py
diff --git a/tools/release/test_scripts.py b/tools/release/test_scripts.py
index
32d0fb837c85f502add80c8c20ab65d6c4bd1c5f..da4f2d10fc894205c8a82adf0f924dc67184462e
100644
--- a/tools/release/test_scripts.py
+++ b/tools/release/test_scripts.py
@@ -1112,6 +1112,7 @@ deps = {
Cmd("git describe --tags bad_tag", ""),
Cmd("git describe --tags hash_234", "3.22.4"),
Cmd("git describe --tags hash_123", "3.22.3"),
+ Cmd("git pull", "", cwd=TEST_CONFIG["CHROMIUM"]),
Cmd("git describe --tags abcd123455", "3.22.4"),
Cmd("git describe --tags hash_234", "3.22.4"),
Cmd("git describe --tags hash_123", "3.22.3"),
@@ -1135,6 +1136,7 @@ deps = {
Cmd("git describe --tags bad_tag", ""),
Cmd("git describe --tags hash_234", "3.22.4"),
Cmd("git describe --tags hash_123", "3.22.3"),
+ Cmd("git pull", "", cwd=TEST_CONFIG["CHROMIUM"]),
Cmd("git describe --tags abcd123455", "3.22.3.1"),
Cmd("git describe --tags hash_234", "3.22.4"),
])
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
