Reviewers: Toon Verwaest, Weiliang,
Message:
PTAL
Description:
X87: Revert of Revert of [strong] Implement strong mode restrictions on
property
access.
port 41405c0470d5b30ec5d22665ed9430c46b33624f (r29122).
fix spelling error in r29122.
BUG=
Please review this at https://codereview.chromium.org/1197593002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+4, -5 lines):
M src/ic/x87/ic-x87.cc
M src/x87/lithium-codegen-x87.cc
Index: src/ic/x87/ic-x87.cc
diff --git a/src/ic/x87/ic-x87.cc b/src/ic/x87/ic-x87.cc
index
daa2ac0fa3f6c249fe9fa68c525a49d017d05f5b..bec2953985011ead2b30241e85d3595d9f36f5be
100644
--- a/src/ic/x87/ic-x87.cc
+++ b/src/ic/x87/ic-x87.cc
@@ -218,7 +218,7 @@ static void GenerateFastArrayLoad(MacroAssembler* masm,
Register receiver,
__ bind(&absent);
if (is_strong(language_mode)) {
// Strong mode accesses must throw in this case, so call the runtime.
- __jmp(slow);
+ __ jmp(slow);
} else {
__ mov(result, masm->isolate()->factory()->undefined_value());
__ jmp(&done);
Index: src/x87/lithium-codegen-x87.cc
diff --git a/src/x87/lithium-codegen-x87.cc b/src/x87/lithium-codegen-x87.cc
index
30ffc1576903d30533a449ab2137a6d70977e928..8d769f76bd4cad4a9d004d174ef8b8f354c0fca7
100644
--- a/src/x87/lithium-codegen-x87.cc
+++ b/src/x87/lithium-codegen-x87.cc
@@ -3468,10 +3468,9 @@ void LCodeGen::DoLoadKeyedGeneric(LLoadKeyedGeneric*
instr) {
EmitVectorLoadICRegisters<LLoadKeyedGeneric>(instr);
}
- Handle<Code> ic = Handle<Code> ic =
- CodeFactory::KeyedLoadICInOptimizedCode(
- isolate(), instr->hydrogen()->language_mode(),
- instr->hydrogen()->initialization_state()).code();
+ Handle<Code> ic = CodeFactory::KeyedLoadICInOptimizedCode(
+ isolate(), instr->hydrogen()->language_mode(),
+ instr->hydrogen()->initialization_state()).code();
CallCode(ic, RelocInfo::CODE_TARGET, instr);
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
