Reviewers: Peter Rybin,

Description:
Fix Windows build by using OS::StrNCpy.

Fix lint issue in lineprocessor.cc.

TBR=peter.rybin

Please review this at http://codereview.chromium.org/549081

SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/

Affected files:
  M     samples/lineprocessor.cc
  M     test/cctest/test-debug.cc


Index: test/cctest/test-debug.cc
===================================================================
--- test/cctest/test-debug.cc   (revision 3640)
+++ test/cctest/test-debug.cc   (working copy)
@@ -2202,7 +2202,8 @@
   if (pos == NULL) {
     return false;
   }
-  strncpy(buffer, pos, buffer_size);
+  Vector<char> buf(buffer, buffer_size);
+  OS::StrNCpy(buf, pos, buffer_size);
   buffer[buffer_size - 1] = '\0';
   return true;
 }
Index: samples/lineprocessor.cc
===================================================================
--- samples/lineprocessor.cc    (revision 3640)
+++ samples/lineprocessor.cc    (working copy)
@@ -404,8 +404,8 @@
 }

 v8::Handle<v8::String> ReadLine() {
-  const int buffer_size = 1024 + 1;
-  char buffer[buffer_size];
+  const int kBufferSize = 1024 + 1;
+  char buffer[kBufferSize];

   char* res;
   {


-- 
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to