LGTM with comments.
I'm shocked that we didn't have test coverage for Math.abs(kMinInt) yet.
https://codereview.chromium.org/1192413002/diff/1/test/mjsunit/math-abs.js
File test/mjsunit/math-abs.js (right):
https://codereview.chromium.org/1192413002/diff/1/test/mjsunit/math-abs.js#newcode134
test/mjsunit/math-abs.js:134: // that sould overflow.
nit: s/sould/should/
https://codereview.chromium.org/1192413002/diff/1/test/mjsunit/math-abs.js#newcode136
test/mjsunit/math-abs.js:136: for (i = 0; i < 1000; i++) {
Please keep the testcase fast:
assertEquals(2147483648, absHalf(bits));
assertEquals(2147483648, absHalf(bits));
%OptimizeFunctionOnNextCall(absHalf);
assertEquals(2147483648, absHalf(bits));
https://codereview.chromium.org/1192413002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
