LGTM
Maybe update the CL description to say that we used to throw an Error and
not a
TypeError. When I first read it I thought: "I know we check for cycles
already"
https://codereview.chromium.org/1198523002/diff/20001/test/mjsunit/harmony/set-prototype-of.js
File test/mjsunit/harmony/set-prototype-of.js (right):
https://codereview.chromium.org/1198523002/diff/20001/test/mjsunit/harmony/set-prototype-of.js#newcode151
test/mjsunit/harmony/set-prototype-of.js:151: var value = objects[i+1];
ws
https://codereview.chromium.org/1198523002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.