Reviewers: Yang, Erik Corry Chromium.org, orion,
Message:
Created Revert of Additional HandleScopes to limit Handle consumption.
Description:
Revert of Additional HandleScopes to limit Handle consumption. (patchset #4
id:50001 of https://codereview.chromium.org/1185633002/)
Reason for revert:
Fails the following test
handle-count-ast
handle-count-runtime-...
on V8 Linux - nosnap - debug - 1
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug%20-%201/builds/851/steps/Check/logs/stdio
Original issue's description:
Additional HandleScopes to limit Handle consumption.
[email protected] suggested digging into v8 handle usage. Found
potential
scopes in ast.cc and runtime-literals.cc and added tests.
The runtime-literals.cc change reduces peak handles in imaging-darkroom.js
from 1,282,610 to 428,218. The ast.cc change reduces the peak handles in
string-tagcloud.js from 80,738 to 8,176.
No significant handle count issues found with major websites, but
substantial
savings on some benchmarks and demos:
Kraken's imaging-darkroom.js down from 1,282,610 to 428,218 due to
runtime-literals.cc scope.
SunSpider's string-tagcloud.js down from 80,738 to 8.176 due to ast.cc
http://www.flohofwoe.net/demos/dragons_asmjs.html (738,906 -> 478,296)
http://www.flohofwoe.net/demos/instancing_asmjs.html (737,884 -> 477,274)
https://dl.dropboxusercontent.com/u/16662598/Ports/DOSBox-web/doom.html?engine=dosbox-growth.js
(1,724,114 -> 1,087,408)
https://kripken.github.io/ammo.js/examples/new/ammo.html (175,784 ->
142,058)
BUG=
Committed: https://crrev.com/3a4c7538839186aa38910c66c986abb563f4ccd2
Cr-Commit-Position: refs/heads/master@{#29155}
[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Please review this at https://codereview.chromium.org/1194873004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+4, -1267 lines):
M src/ast.cc
M src/handles.h
M src/handles-inl.h
M src/heap/heap.cc
M src/runtime/runtime-literals.cc
M test/cctest/test-types.cc
D test/mjsunit/handle-count-ast.js
D test/mjsunit/handle-count-runtime-literals.js
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
