I will suggest to putting this heap configuration into the Heap class together
with the "normal" heap confuguration like max_semispace_size_ /
MaxSemiSpaceSize(), and have a setter function for it whorking like
Heap::ConfigureHeap(int, int).

Also I suggest you call it max_map_space_pages_ / MaxMapSpacePages() /
SetMaxMapSpacePages(int).

Also on top of that adding a flag for it could be interesting as it would make it easy to run all the tests with small map space - that could be interesting.
The following command runs all tests with the additional option
"--max-map-space-pages=64"

../tools/test.py --special-command "@ --max-map-space-pages=64" mode=debug


http://codereview.chromium.org/543113
-- 
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to