Reviewers: Erik Corry Chromium.org, rmcilroy, Yang,
Message:
PTAL - attempting to reland handle count patch. This change just increases
handle count limit from 16K to 30K. This is ample to compile natives and
run the
check_handle_count unit tests on failing bots.
Description:
Reland 'Additional HandleScopes to limit Handle consumption.'
v8 builds with --no-snap were hitting handle limits compiling natives for
handle
count unit tests that run with --check_handle_count. Patch now has higher
handle
limits (~4k more than required for failing natives compilation).
Original issue: https://codereview.chromium.org/1185633002/
Original issue's description:
> Additional HandleScopes to limit Handle consumption.
>
> [email protected] suggested digging into v8 handle usage. Found
potential scopes in ast.cc and runtime-literals.cc and added tests.
>
> The runtime-literals.cc change reduces peak handles in
imaging-darkroom.js
from 1,282,610 to 428,218. The ast.cc change reduces the peak handles in
string-t
agcloud.js from 80,738 to 8,176.
>
> No significant handle count issues found with major websites, but
substantial savings on some benchmarks and demos:
>
> Kraken's imaging-darkroom.js down from 1,282,610 to 428,218 due to
runtime-literals.cc scope.
> SunSpider's string-tagcloud.js down from 80,738 to 8.176 due to ast.cc
>
> http://www.flohofwoe.net/demos/dragons_asmjs.html (738,906 -> 478,296)
> http://www.flohofwoe.net/demos/instancing_asmjs.html (737,884 ->
477,274)
>
https://dl.dropboxusercontent.com/u/16662598/Ports/DOSBox-web/doom.html?engine=dosbox-growth.js
(1,724,114 -> 1,087,408)
> https://kripken.github.io/ammo.js/examples/new/ammo.html (175,784 ->
142,058)
>
> BUG=
>
> Committed: https://crrev.com/3a4c7538839186aa38910c66c986abb563f4ccd2
> Cr-Commit-Position: refs/heads/master@{#29155}
BUG=
Please review this at https://codereview.chromium.org/1192743005/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1263, -13 lines):
M src/ast.cc
M src/handles.h
M src/handles-inl.h
M src/heap/heap.cc
M src/runtime/runtime-literals.cc
M test/cctest/test-types.cc
A + test/mjsunit/handle-count-ast.js
A test/mjsunit/handle-count-runtime-literals.js
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
