Reviewers: Mads Ager, Søren Gjesse,
Message:
Gentlemen,
I'm sorry, the previous fix was really bad, though it passes on Linux.
I applying patch manually, a put "- 1" to wrong line.
Also I shouldn't have remove '\n' because it doesn't do it on linux itself.
Peter
Description:
Re-Fix DebugEvaluateWithoutStack test on Windows
Please review this at http://codereview.chromium.org/545118
Affected files:
M test/cctest/test-debug.cc
Index: test/cctest/test-debug.cc
diff --git a/test/cctest/test-debug.cc b/test/cctest/test-debug.cc
index
d03785056d385f6f901e6ef6f2aa20070931ecf7..b69ecccd6b791aeea40694d47368e47b7605f929
100644
--- a/test/cctest/test-debug.cc
+++ b/test/cctest/test-debug.cc
@@ -2202,8 +2202,9 @@ bool GetEvaluateStringResult(char *message, char*
buffer, int buffer_size) {
if (pos == NULL) {
return false;
}
- Vector<char> buf(buffer, buffer_size - 1);
- OS::StrNCpy(buf, pos, buffer_size);
+ Vector<char> buf(buffer, buffer_size);
+ OS::StrNCpy(buf, pos, buffer_size - 1);
+ buffer[buffer_size - 1] = '\0';
return true;
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
