https://codereview.chromium.org/1191243003/diff/60001/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/1191243003/diff/60001/src/compiler/ast-graph-builder.cc#newcode452
src/compiler/ast-graph-builder.cc:452:
FrameStateType::kJavaScriptFunction, info->num_parameters() + 1,
Nit: Use info->num_parameters_including_this() here?
https://codereview.chromium.org/1191243003/diff/60001/src/compiler/common-operator.cc
File src/compiler/common-operator.cc (right):
https://codereview.chromium.org/1191243003/diff/60001/src/compiler/common-operator.cc#newcode782
src/compiler/common-operator.cc:782: return new
(zone()->New(sizeof(FrameStateFunctionInfo)))
Turn the FrameStateFunctionInfo into a ZoneObject and avoid placement
new here?
https://codereview.chromium.org/1191243003/diff/60001/src/compiler/frame-states.cc
File src/compiler/frame-states.cc (right):
https://codereview.chromium.org/1191243003/diff/60001/src/compiler/frame-states.cc#newcode32
src/compiler/frame-states.cc:32: lhs.state_combine() ==
rhs.state_combine();
I guess we also need lhs.info() == rhs.info() here.
https://codereview.chromium.org/1191243003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
