LGTM with comments.
https://codereview.chromium.org/1197133003/diff/60001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1197133003/diff/60001/src/objects.cc#newcode12428
src/objects.cc:12428: DCHECK(!(value->IsSmi() &&
object->HasFastDoubleElements()));
AFAICS you can DCHECK(!object->HasFastDoubleElements()) here.
https://codereview.chromium.org/1197133003/diff/60001/src/objects.cc#newcode12673
src/objects.cc:12673: if (introduces_holes &&
object->HasFastHoleyElements()) {
I think you want to keep the '!'.
https://codereview.chromium.org/1197133003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
