Reviewers: dstence, michael_dawson,
Description:
PPC: Clean up JSConstructStub
Port 882055ff6a58f6b585575229f40f364e5f2a3ad0
Original commit message:
- fix truthfulness of comments
- use InitializeFieldsWithFiller more consistently
- use unsigned comparisons for pointers
No change in functionality intended.
Bonus: improve JavaScriptFrame::Print() for an enhanced debugging
experience:
- print PC of each frame
- print the function's source also for optimized frames
[email protected], [email protected]
BUG=
Please review this at https://codereview.chromium.org/1193363004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -2 lines):
M src/ppc/builtins-ppc.cc
Index: src/ppc/builtins-ppc.cc
diff --git a/src/ppc/builtins-ppc.cc b/src/ppc/builtins-ppc.cc
index
5935896205dc11cafc655f2bbdf9f56c2bda38a9..256f92447ec0c08c7bdf6dc0faf11e2f266d9c15
100644
--- a/src/ppc/builtins-ppc.cc
+++ b/src/ppc/builtins-ppc.cc
@@ -439,7 +439,7 @@ static void
Generate_JSConstructStubHelper(MacroAssembler* masm,
// initial map and properties and elements are set to empty fixed
array.
// r4: constructor function
// r5: initial map
- // r6: object size (not including memento if create_memento)
+ // r6: object size (including memento if create_memento)
// r7: JSObject (not tagged)
__ LoadRoot(r9, Heap::kEmptyFixedArrayRootIndex);
__ mr(r8, r7);
@@ -516,7 +516,7 @@ static void
Generate_JSConstructStubHelper(MacroAssembler* masm,
__ addi(r7, r7, Operand(kHeapObjectTag));
// Check if a non-empty properties array is needed. Continue with
- // allocated object if not fall through to runtime call if it is.
+ // allocated object if not; allocate and initialize a FixedArray if
yes.
// r4: constructor function
// r7: JSObject
// r8: start of next object (not tagged)
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
