This seems like something it would not take long to fix, so I think we should just fix it.
Thanks, -- Mads On Tue, Jan 19, 2010 at 5:25 PM, <[email protected]> wrote: > I totally agree we ought to fix this. I think clearly reads between the > lines of > comment :) > > The only question is should we put the current doc (possibly with TODO) now > or > not. > I got used to putting docs/TODO first, and then fixing it. > However, it's a matter of taste. > > On 2010/01/19 16:13:06, Søren Gjesse wrote: >> >> http://codereview.chromium.org/552042/diff/1001/4 >> File src/platform.h (right): > >> http://codereview.chromium.org/552042/diff/1001/4#newcode244 >> src/platform.h:244: // Calls strncpy in POSIX and strncpy_s in Windows. It > > means >> >> that >> Then we should probably stick to the strncpy_s semantics where the dest[0] >> is >> set to '\0' if dest does not have room for the n characters. > > > > http://codereview.chromium.org/552042 >
-- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
