Hi Michael, thanks for the good comments. I also fixed a typo from the
previous
CL.
Best,
--Michael
https://codereview.chromium.org/1193313002/diff/1/src/compiler/js-operator.cc
File src/compiler/js-operator.cc (right):
https://codereview.chromium.org/1193313002/diff/1/src/compiler/js-operator.cc#newcode516
src/compiler/js-operator.cc:516: int inputs = FLAG_vector_stores ? 3 :
2;
On 2015/06/22 08:40:55, Michael Starzinger wrote:
Can we make the number of inputs always be 3 for this operator? If
FLAG_vector_stores are off we can just pass undefined to the operator
and remove
it in generic lowering. But having different number of inputs
depending on a
flag seems brittle.
Good idea. In fact, we can just pass the feedback vector too. Done.
https://codereview.chromium.org/1193313002/diff/1/src/compiler/js-operator.cc#newcode528
src/compiler/js-operator.cc:528: int inputs = FLAG_vector_stores ? 4 :
3;
On 2015/06/22 08:40:55, Michael Starzinger wrote:
Likewise for always having 4 inputs.
Done.
https://codereview.chromium.org/1193313002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
