With these changes to the SConstruct file the pseudo architecture mips-simu should not be needed.
http://codereview.chromium.org/549079/diff/1/67 File SConstruct (right): http://codereview.chromium.org/549079/diff/1/67#newcode176 SConstruct:176: 'arch:mips': { If you change this section to 'CPPDEFINES': ['V8_TARGET_ARCH_MIPS'], 'simulator:none': { 'CCFLAGS': ['-EL', '-mips32r2', '-Wa,-mips32r2', '-fno-inline'], 'LDFLAGS': ['-EL'] } The flags for the MIPS gcc will now only become active when not compiling for the simulator. http://codereview.chromium.org/549079/diff/1/67#newcode185 SConstruct:185: 'arch:mips-simu': { With the change to arch:mips above the pseudo arch mips-simu is no longer needed. http://codereview.chromium.org/549079/diff/1/67#newcode300 SConstruct:300: 'arch:mips-simu': { With the change to arch:mips above the pseudo arch mips-simu is no longer needed. http://codereview.chromium.org/549079/diff/1/67#newcode301 SConstruct:301: 'CPPDEFINES': ['V8_TARGET_ARCH_MIPS', 'NO_NATIVES', 'MIPS_SIMU'], There is no active use of defines NO_NATIVES and MIPS_SIMU in the code. http://codereview.chromium.org/549079/diff/1/67#newcode445 SConstruct:445: 'arch:mips': { Change this section like this: 'CPPDEFINES': ['V8_TARGET_ARCH_MIPS'], 'simulator:none': { 'CCFLAGS': ['-EL', '-mips32r2', '-Wa,-mips32r2', '-fno-inline'], 'LINKFLAGS': ['-EL'], 'LDFLAGS': ['-EL'] } http://codereview.chromium.org/549079/diff/1/67#newcode451 SConstruct:451: 'arch:mips-simu': { With the change to arch:mips above the pseudo arch mips-simu is no longer needed. http://codereview.chromium.org/549079/diff/1/67#newcode796 SConstruct:796: if (self.options['simulator'] == 'mips' and value == 'mips'): value = 'mips-simu' This seems wrong. It will overwrite both the value of 'arch' and the value of 'simulator'. This in turn causes the gcc section simulator:mips to be ignored so the -m32 option are missing when compiling on a 64-bit linux. With changes above this should not be needed any more. http://codereview.chromium.org/549079/diff/1/67#newcode859 SConstruct:859: # options['arch'] = 'mips' Chis change should not be needed when the pseudo architecture mips-simu gets removed. http://codereview.chromium.org/549079
-- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
