LGTM with comments. The naming suggestion applies to all platforms.
https://codereview.chromium.org/1210583002/diff/1/src/ic/arm/ic-arm.cc
File src/ic/arm/ic-arm.cc (right):
https://codereview.chromium.org/1210583002/diff/1/src/ic/arm/ic-arm.cc#newcode676
src/ic/arm/ic-arm.cc:676:
masm->isolate()->factory()->keyed_load_dummy_vector());
keyed *load* dummy vector?! Oh man, you're full of surprises!
https://codereview.chromium.org/1210583002/diff/1/src/ic/arm64/ic-arm64.cc
File src/ic/arm64/ic-arm64.cc (right):
https://codereview.chromium.org/1210583002/diff/1/src/ic/arm64/ic-arm64.cc#newcode674
src/ic/arm64/ic-arm64.cc:674:
masm->isolate()->factory()->keyed_load_dummy_vector());
s/load/store/
https://codereview.chromium.org/1210583002/diff/1/src/ic/x64/ic-x64.cc
File src/ic/x64/ic-x64.cc (right):
https://codereview.chromium.org/1210583002/diff/1/src/ic/x64/ic-x64.cc#newcode567
src/ic/x64/ic-x64.cc:567: int int_slot =
dummy_vector->GetIndex(FeedbackVectorICSlot(0));
nit: naming suggestion: s/int_slot/slot_index/
https://codereview.chromium.org/1210583002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
