Thanks for the review. I've addressed the nits and fixed the win64 build.
PTAL.
https://codereview.chromium.org/1191513003/diff/80001/src/compiler/arm/code-generator-arm.cc
File src/compiler/arm/code-generator-arm.cc (right):
https://codereview.chromium.org/1191513003/diff/80001/src/compiler/arm/code-generator-arm.cc#newcode954
src/compiler/arm/code-generator-arm.cc:954:
DCHECK(DwVfpRegister::kMaxNumRegisters == 32);
On 2015/06/24 07:04:21, Benedikt Meurer wrote:
Nit: How about a static assert here?
Done.
https://codereview.chromium.org/1191513003/diff/80001/src/compiler/arm/code-generator-arm.cc#newcode957
src/compiler/arm/code-generator-arm.cc:957: DCHECK((last - first + 1) ==
base::bits::CountPopulation32(saves_fp));
On 2015/06/24 07:04:21, Benedikt Meurer wrote:
Nit: How about DCHECK_EQ?
Done.
https://codereview.chromium.org/1191513003/diff/80001/src/compiler/arm/code-generator-arm.cc#newcode1011
src/compiler/arm/code-generator-arm.cc:1011:
DCHECK(DwVfpRegister::kMaxNumRegisters == 32);
On 2015/06/24 07:04:21, Benedikt Meurer wrote:
Nit: STATIC_ASSERT?
Done.
https://codereview.chromium.org/1191513003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
