Reviewers: Benedikt Meurer,
Message:
Hi Benedikt,
This is the arm64 port for issue 1205023002.
It passes the extra test on real hardware.
Cheers,
Baptiste
Description:
[turbofan][arm64] Add support for calling to (a subset of) C functions.
[email protected]
Please review this at https://codereview.chromium.org/1205033003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+20, -5 lines):
M src/compiler/arm64/code-generator-arm64.cc
M src/compiler/arm64/instruction-selector-arm64.cc
Index: src/compiler/arm64/code-generator-arm64.cc
diff --git a/src/compiler/arm64/code-generator-arm64.cc
b/src/compiler/arm64/code-generator-arm64.cc
index
736d5638d8edddb63ade5e5c4bf5c1e2d67675c4..38616ff08df5135023474558475022f4bf62f0a8
100644
--- a/src/compiler/arm64/code-generator-arm64.cc
+++ b/src/compiler/arm64/code-generator-arm64.cc
@@ -420,6 +420,18 @@ void
CodeGenerator::AssembleArchInstruction(Instruction* instr) {
__ Jump(x10);
break;
}
+ case kArchPrepareCallCFunction:
+ // We don't need kArchPrepareCallCFunction on arm64 as the
instruction
+ // selector already perform a Claim to reserve space on the stack and
+ // guarantee correct alignment of stack pointer.
+ UNREACHABLE();
+ break;
+ case kArchCallCFunction: {
+ int const num_parameters = MiscField::decode(instr->opcode());
+ Register func = i.InputRegister(0);
+ __ CallCFunction(func, num_parameters, 0);
+ break;
+ }
case kArchJmp:
AssembleArchJump(i.InputRpo(0));
break;
Index: src/compiler/arm64/instruction-selector-arm64.cc
diff --git a/src/compiler/arm64/instruction-selector-arm64.cc
b/src/compiler/arm64/instruction-selector-arm64.cc
index
e051d65a06871b28cc7a3fa0ddaef5e243487530..43eb394c06d590bdb812831209a6c0320f48dfa4
100644
--- a/src/compiler/arm64/instruction-selector-arm64.cc
+++ b/src/compiler/arm64/instruction-selector-arm64.cc
@@ -1392,18 +1392,21 @@ void InstructionSelector::VisitCall(Node* node,
BasicBlock* handler) {
// Select the appropriate opcode based on the call type.
InstructionCode opcode;
switch (descriptor->kind()) {
- case CallDescriptor::kCallCodeObject: {
- opcode = kArchCallCodeObject;
+ case CallDescriptor::kCallAddress:
+ opcode =
+ kArchCallCFunction |
+
MiscField::encode(static_cast<int>(descriptor->CParameterCount()));
+ break;
+ case CallDescriptor::kCallCodeObject:
+ opcode = kArchCallCodeObject | MiscField::encode(flags);
break;
- }
case CallDescriptor::kCallJSFunction:
- opcode = kArchCallJSFunction;
+ opcode = kArchCallJSFunction | MiscField::encode(flags);
break;
default:
UNREACHABLE();
return;
}
- opcode |= MiscField::encode(flags);
// Emit the call instruction.
size_t const output_count = buffer.outputs.size();
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
