I'm guessing you're going to want to use the base/trace_event/trace_event.h
instead of the Skia one as it's older then what is in base at this
point ....
https://codereview.chromium.org/988893003/diff/200001/include/v8-tracing.h
File include/v8-tracing.h (right):
https://codereview.chromium.org/988893003/diff/200001/include/v8-tracing.h#newcode41
include/v8-tracing.h:41: };
There is also a ENABLED_FOR_ETW_EXPORT = 1 << 3 should that be here for
completeness, or a note that it's skipped on purpose?
https://codereview.chromium.org/988893003/diff/200001/src/tracing/trace-event.h
File src/tracing/trace-event.h (right):
https://codereview.chromium.org/988893003/diff/200001/src/tracing/trace-event.h#newcode895
src/tracing/trace-event.h:895: #define TRACE_EVENT_PHASE_INSTANT ('i')
This doesn't match the base/trace_event/trace_event.h. It lists Instant
as "I"
https://codereview.chromium.org/988893003/diff/200001/src/tracing/trace-event.h#newcode900
src/tracing/trace-event.h:900: #define TRACE_EVENT_PHASE_FLOW_BEGIN
('s')
The NESTABLE_ASYNC_ stuff is missing from here (and I'm assuming the
code above). We're phasing out async in favour of nestable async.
https://codereview.chromium.org/988893003/diff/200001/src/tracing/trace-event.h#newcode909
src/tracing/trace-event.h:909:
PHASE_MEMORY_DUMP 'v' is missing
https://codereview.chromium.org/988893003/diff/200001/src/tracing/trace-event.h#newcode916
src/tracing/trace-event.h:916:
There are a few flags missing from here _SCOPE_EXTRA,
_EXPLICIT_TIMESTAMP, _ASYNC_TTS
https://codereview.chromium.org/988893003/diff/200001/src/tracing/trace-event.h#newcode917
src/tracing/trace-event.h:917: #define TRACE_EVENT_FLAG_SCOPE_MA
\
Seem to have lost the SK on the end? SCOPE_MASK
https://codereview.chromium.org/988893003/diff/200001/src/tracing/trace-event.h#newcode919
src/tracing/trace-event.h:919: (TRACE_EVENT_FLAG_SCOPE_OFFSET << 1)))
This is SCOPE_EXTRA in the base version.
https://codereview.chromium.org/988893003/diff/200001/src/tracing/trace-event.h#newcode932
src/tracing/trace-event.h:932: // TRACE_EVENT_FLAG_SCOPE_MA.
SK
https://codereview.chromium.org/988893003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
