Reviewers: ulan,
Description:
Debugger: remove bogus assertion in BreakLocation constructor.
Currently DebugInfo objects can be created independelty from whether
the debugger is active. When tearing down the isolate, we would go
through DebugInfo objects and iterate through break locations,
causing this assertion to fail.
[email protected]
BUG=v8:4241
LOG=N
Please review this at https://codereview.chromium.org/1210813002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1, -3 lines):
M src/debug.cc
Index: src/debug.cc
diff --git a/src/debug.cc b/src/debug.cc
index
d966b6e7391c059b6e03cbb870e41813cb2d3895..c414e23d39b9bc86580efa349163c59dbf215441
100644
--- a/src/debug.cc
+++ b/src/debug.cc
@@ -70,9 +70,7 @@ BreakLocation::BreakLocation(Handle<DebugInfo>
debug_info, RelocInfo* rinfo,
data_(rinfo->data()),
original_data_(original_rinfo->data()),
position_(position),
- statement_position_(statement_position) {
- DCHECK(debug_info_->GetIsolate()->debug()->is_active());
-}
+ statement_position_(statement_position) {}
BreakLocation::Iterator::Iterator(Handle<DebugInfo> debug_info,
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
