Reviewers: arv,
Message:
Patch 1 is what landed originally. Patch 2 records the source location for
the
callee in lookup eval calls. The error that was originally seen was that
in one
layout test that triggered an error and matched on the backtrace, line
numbers
were off. I have verified that this patch fixes that error and will kick
off a
blink test to make sure it hasn't regressed anything else.
Description:
Reapply "Fix receiver when calling eval() bound by with scope"
Originally applied in https://codereview.chromium.org/1202963005
BUG=v8:4214
LOG=N
[email protected], [email protected]
Please review this at https://codereview.chromium.org/1208873002/
Base URL: https://chromium.googlesource.com/v8/v8@master
Affected files (+408, -325 lines):
M src/arm/full-codegen-arm.cc
M src/arm64/full-codegen-arm64.cc
M src/ast.h
M src/compiler/ast-graph-builder.cc
M src/full-codegen.h
M src/ia32/full-codegen-ia32.cc
M src/mips/full-codegen-mips.cc
M src/mips64/full-codegen-mips64.cc
M src/ppc/full-codegen-ppc.cc
M src/x64/full-codegen-x64.cc
M src/x87/full-codegen-x87.cc
A + test/mjsunit/regress/regress-4214.js
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
