How about this then, Erik?
http://codereview.chromium.org/546087/diff/6001/7001 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/546087/diff/6001/7001#newcode5209 src/arm/codegen-arm.cc:5209: // Both the builtin and the StringCompareStub code expects arguments on the Actually comment is no longer correct. I changed the GenerateComplareFlat.... to not expect arguments lying around on the stack. Comment removed. http://codereview.chromium.org/546087/diff/6001/7001#newcode6809 src/arm/codegen-arm.cc:6809: __ b(gt, &result_greater); On 2010/01/21 10:23:19, Erik Corry wrote:
This b could be eliminated by using conditional mov.
Interesting. Let's see how much crud can be eliminated by just making the moves conditional. http://codereview.chromium.org/546087/diff/6001/7001#newcode6824 src/arm/codegen-arm.cc:6824: __ b(gt, &result_greater); On 2010/01/21 10:23:19, Erik Corry wrote:
I recommended this, but now I would suggest conditional mov instead.
In fact if
you use r0 instead of length_delta then you don't need to move 0 to
the
register.
Done. http://codereview.chromium.org/546087
-- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev
