PTAL at patch 3.
https://codereview.chromium.org/1207693004/diff/1/Makefile.android
File Makefile.android (left):
https://codereview.chromium.org/1207693004/diff/1/Makefile.android#oldcode47
Makefile.android:47: DEFINES += android_target_arch=mips
mips_arch_variant=mips32r2
On 2015/06/24 16:08:23, dusmil.imgtec wrote:
On 2015/06/24 14:53:31, Michael Achenbach wrote:
I see now this is not a gyp variable and most likely it does not have
any
effect.
I'll delete mips_arch_variant as it has no effect. A further code-smell
is that in our standalon.gypi, the mips_arch_variant is set to r2 by
default, but then there is no code that reads the variable at all. In
chromium's common.gypi, several cflags are set/unset based on the
variant version.
https://codereview.chromium.org/1207693004/diff/20001/Makefile.android
File Makefile.android (right):
https://codereview.chromium.org/1207693004/diff/20001/Makefile.android#newcode40
Makefile.android:40: DEFINES += arm_neon=0 arm_version=7
Moving arm_version into gypi. Deleting neon=0 as it is not read in our
gypi files. Our default configuration is for neon=0.
https://codereview.chromium.org/1207693004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
