Thanks a lot for review, Søren.
http://code.google.com/p/v8/issues/detail?id=586 filed and referenced in
changed
files.
yours,
anton.
On 2010/01/21 07:57:41, Søren Gjesse wrote:
LGTM
I think you should raise a bug on the iterator next()/has_next()
semantics to
track this issue. Maybe add a reference from the bug to this change.
http://codereview.chromium.org/552066/diff/1/5
File src/mark-compact.cc (right):
http://codereview.chromium.org/552066/diff/1/5#newcode1294
src/mark-compact.cc:1294: it.has_next();
Please add a comment here.
http://codereview.chromium.org/552066/diff/1/3
File src/spaces.h (right):
http://codereview.chromium.org/552066/diff/1/3#newcode1803
src/spaces.h:1803: it.has_next();
Please add a comment here.
http://codereview.chromium.org/552066/diff/1/3#newcode1807
src/spaces.h:1807: it.has_next();
And here.
http://codereview.chromium.org/552066
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
