Reviewers: jochen,
Message:
PTAL.
There are a few things left after this:
GYP: unused simulators + vtune
GN: the same + the things that didn't migrate to GN at all yet.
Description:
Fix missing source dependencies.
BUG=
Please review this at https://codereview.chromium.org/1217483002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+52, -3 lines):
M BUILD.gn
M src/d8.gyp
M tools/gyp/v8.gyp
M tools/verify_source_deps.py
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index
4169ed54dbc206321f83274110481cadd631101d..c97ad62c43614c322bcb25c27cedfebbe51f0ef4
100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -536,6 +536,14 @@ source_set("v8_base") {
visibility = [ ":*" ] # Only targets in this file can depend on this.
sources = [
+ "../../include/v8-debug.h",
+ "../../include/v8-platform.h",
+ "../../include/v8-profiler.h",
+ "../../include/v8-testing.h",
+ "../../include/v8-util.h",
+ "../../include/v8-version.h",
+ "../../include/v8.h",
+ "../../include/v8config.h",
"src/accessors.cc",
"src/accessors.h",
"src/allocation.cc",
@@ -1046,6 +1054,7 @@ source_set("v8_base") {
"src/scopes.cc",
"src/scopes.h",
"src/signature.h",
+ "src/simulator.h",
"src/small-pointer-list.h",
"src/smart-pointers.h",
"src/snapshot/natives.h",
@@ -1054,6 +1063,8 @@ source_set("v8_base") {
"src/snapshot/snapshot-common.cc",
"src/snapshot/snapshot-source-sink.cc",
"src/snapshot/snapshot-source-sink.h",
+ "src/splay-tree.h",
+ "src/splay-tree-inl.h",
"src/snapshot/snapshot.h",
"src/string-builder.cc",
"src/string-builder.h",
@@ -1103,6 +1114,8 @@ source_set("v8_base") {
"src/vm-state.h",
"src/zone.cc",
"src/zone.h",
+ "src/zone-allocator.h",
+ "src/zone-containers.h",
"src/third_party/fdlibm/fdlibm.cc",
"src/third_party/fdlibm/fdlibm.h",
]
@@ -1215,6 +1228,7 @@ source_set("v8_base") {
"src/arm/regexp-macro-assembler-arm.cc",
"src/arm/regexp-macro-assembler-arm.h",
"src/arm/simulator-arm.cc",
+ "src/arm/simulator-arm.h",
"src/compiler/arm/code-generator-arm.cc",
"src/compiler/arm/instruction-codes-arm.h",
"src/compiler/arm/instruction-selector-arm.cc",
@@ -1309,6 +1323,7 @@ source_set("v8_base") {
"src/mips/regexp-macro-assembler-mips.cc",
"src/mips/regexp-macro-assembler-mips.h",
"src/mips/simulator-mips.cc",
+ "src/mips/simulator-mips.h",
"src/compiler/mips/code-generator-mips.cc",
"src/compiler/mips/instruction-codes-mips.h",
"src/compiler/mips/instruction-selector-mips.cc",
@@ -1350,6 +1365,7 @@ source_set("v8_base") {
"src/mips64/regexp-macro-assembler-mips64.cc",
"src/mips64/regexp-macro-assembler-mips64.h",
"src/mips64/simulator-mips64.cc",
+ "src/mips64/simulator-mips64.h",
"src/ic/mips64/access-compiler-mips64.cc",
"src/ic/mips64/handler-compiler-mips64.cc",
"src/ic/mips64/ic-mips64.cc",
@@ -1413,6 +1429,8 @@ source_set("v8_libbase") {
"src/base/atomicops_internals_atomicword_compat.h",
"src/base/atomicops_internals_mac.h",
"src/base/atomicops_internals_mips_gcc.h",
+ "src/base/atomicops_internals_mips64_gcc.h",
+ "src/base/atomicops_internals_portable.h",
"src/base/atomicops_internals_tsan.h",
"src/base/atomicops_internals_x86_gcc.cc",
"src/base/atomicops_internals_x86_gcc.h",
@@ -1682,6 +1700,7 @@ if ((current_toolchain == host_toolchain &&
v8_toolset_for_d8 == "host") ||
if (!is_component_build) {
sources += [
"src/d8-debug.cc",
+ "src/d8-debug.h",
"$target_gen_dir/d8-js.cc",
]
}
Index: src/d8.gyp
diff --git a/src/d8.gyp b/src/d8.gyp
index
a78551599fb0992a4519754e7a62a8dc2727b1e2..548459a7901463e8c8d1b9785d25b267fed95419
100644
--- a/src/d8.gyp
+++ b/src/d8.gyp
@@ -48,6 +48,7 @@
'..',
],
'sources': [
+ 'd8.h',
'd8.cc',
'startup-data-util.h',
'startup-data-util.cc'
@@ -69,7 +70,11 @@
'sources': [ 'd8-windows.cc', ]
}],
[ 'component!="shared_library"', {
- 'sources':
[ 'd8-debug.cc', '<(SHARED_INTERMEDIATE_DIR)/d8-js.cc', ],
+ 'sources': [
+ 'd8-debug.h',
+ 'd8-debug.cc',
+ '<(SHARED_INTERMEDIATE_DIR)/d8-js.cc',
+ ],
'conditions': [
[ 'want_separate_host_toolset==1', {
'dependencies': [
Index: tools/gyp/v8.gyp
diff --git a/tools/gyp/v8.gyp b/tools/gyp/v8.gyp
index
6e1c7078414f79ea6e0ec933a157b8b12ecac124..9be673f8da3bf61c48e534065c8463bbdc131611
100644
--- a/tools/gyp/v8.gyp
+++ b/tools/gyp/v8.gyp
@@ -369,6 +369,14 @@
'V8_IMMINENT_DEPRECATION_WARNINGS',
],
'sources': [ ### gcmole(all) ###
+ '../../include/v8-debug.h',
+ '../../include/v8-platform.h',
+ '../../include/v8-profiler.h',
+ '../../include/v8-testing.h',
+ '../../include/v8-util.h',
+ '../../include/v8-version.h',
+ '../../include/v8.h',
+ '../../include/v8config.h',
'../../src/accessors.cc',
'../../src/accessors.h',
'../../src/allocation.cc',
@@ -880,6 +888,7 @@
'../../src/scopes.cc',
'../../src/scopes.h',
'../../src/signature.h',
+ '../../src/simulator.h',
'../../src/small-pointer-list.h',
'../../src/smart-pointers.h',
'../../src/snapshot/natives.h',
@@ -889,6 +898,8 @@
'../../src/snapshot/snapshot-common.cc',
'../../src/snapshot/snapshot-source-sink.cc',
'../../src/snapshot/snapshot-source-sink.h',
+ '../../src/splay-tree.h',
+ '../../src/splay-tree-inl.h',
'../../src/string-builder.cc',
'../../src/string-builder.h',
'../../src/string-search.cc',
@@ -940,6 +951,8 @@
'../../src/vm-state.h',
'../../src/zone.cc',
'../../src/zone.h',
+ '../../src/zone-allocator.h',
+ '../../src/zone-containers.h',
'../../src/third_party/fdlibm/fdlibm.cc',
'../../src/third_party/fdlibm/fdlibm.h',
],
@@ -981,6 +994,7 @@
'../../src/arm/regexp-macro-assembler-arm.cc',
'../../src/arm/regexp-macro-assembler-arm.h',
'../../src/arm/simulator-arm.cc',
+ '../../src/arm/simulator-arm.h',
'../../src/compiler/arm/code-generator-arm.cc',
'../../src/compiler/arm/instruction-codes-arm.h',
'../../src/compiler/arm/instruction-selector-arm.cc',
@@ -1158,6 +1172,7 @@
'../../src/mips/regexp-macro-assembler-mips.cc',
'../../src/mips/regexp-macro-assembler-mips.h',
'../../src/mips/simulator-mips.cc',
+ '../../src/mips/simulator-mips.h',
'../../src/compiler/mips/code-generator-mips.cc',
'../../src/compiler/mips/instruction-codes-mips.h',
'../../src/compiler/mips/instruction-selector-mips.cc',
@@ -1200,6 +1215,7 @@
'../../src/mips64/regexp-macro-assembler-mips64.cc',
'../../src/mips64/regexp-macro-assembler-mips64.h',
'../../src/mips64/simulator-mips64.cc',
+ '../../src/mips64/simulator-mips64.h',
'../../src/compiler/mips64/code-generator-mips64.cc',
'../../src/compiler/mips64/instruction-codes-mips64.h',
'../../src/compiler/mips64/instruction-selector-mips64.cc',
@@ -1286,6 +1302,7 @@
'../../src/ppc/regexp-macro-assembler-ppc.cc',
'../../src/ppc/regexp-macro-assembler-ppc.h',
'../../src/ppc/simulator-ppc.cc',
+ '../../src/ppc/simulator-ppc.h',
'../../src/compiler/ppc/code-generator-ppc.cc',
'../../src/compiler/ppc/instruction-codes-ppc.h',
'../../src/compiler/ppc/instruction-selector-ppc.cc',
@@ -1364,6 +1381,8 @@
'../../src/base/atomicops_internals_atomicword_compat.h',
'../../src/base/atomicops_internals_mac.h',
'../../src/base/atomicops_internals_mips_gcc.h',
+ '../../src/base/atomicops_internals_mips64_gcc.h',
+ '../../src/base/atomicops_internals_portable.h',
'../../src/base/atomicops_internals_ppc_gcc.h',
'../../src/base/atomicops_internals_tsan.h',
'../../src/base/atomicops_internals_x86_gcc.cc',
Index: tools/verify_source_deps.py
diff --git a/tools/verify_source_deps.py b/tools/verify_source_deps.py
index
f395d4b87ca80fcd5745ae8d55c5b04cdfe0c603..50caace79c8e71903379441e504001243e281755
100755
--- a/tools/verify_source_deps.py
+++ b/tools/verify_source_deps.py
@@ -7,6 +7,10 @@
Script to print potentially missing source dependencies based on the actual
.h and .cc files in the source tree and which files are included in the gyp
and gn files. The latter inclusion is overapproximated.
+
+TODO(machenbach): Gyp files in src will point to source files in src
without a
+src/ prefix. For simplicity, all paths relative to src are stripped. But
this
+tool won't be accurate for other sources in other directories (e.g.
cctest).
"""
import itertools
@@ -31,6 +35,8 @@ GYP_FILES = [
def path_no_prefix(path):
if path.startswith('../'):
return path_no_prefix(path[3:])
+ elif path.startswith('src/'):
+ return path_no_prefix(path[4:])
else:
return path
@@ -40,7 +46,7 @@ def isources(directory):
for f in files:
if not (f.endswith('.h') or f.endswith('.cc')):
continue
- yield os.path.relpath(os.path.join(root, f), V8_BASE)
+ yield path_no_prefix(os.path.relpath(os.path.join(root, f), V8_BASE))
def iflatten(obj):
@@ -74,7 +80,7 @@ def iflatten_gn_file(gn_file):
for line in f.read().splitlines():
match = re.match(r'.*"([^"]*)".*', line)
if match:
- yield match.group(1)
+ yield path_no_prefix(match.group(1))
def icheck_values(values, *source_dirs):
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
