Reviewers: Benedikt Meurer, dstence, michael_dawson,
Description:
PPC: [turbofan] Canonicalize return sequence for JSFunctions.
Port 2b9112a578f66fc976557aededf3e203f48c395e
Original commit message:
This optimization is already implemented in fullcodegen, and
basically makes sure that we do not unecessarily blow up the
code with duplicated return sequences everywhere.
[email protected], [email protected], [email protected]
BUG=
Please review this at https://codereview.chromium.org/1218493003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+11, -5 lines):
M src/compiler/ppc/code-generator-ppc.cc
Index: src/compiler/ppc/code-generator-ppc.cc
diff --git a/src/compiler/ppc/code-generator-ppc.cc
b/src/compiler/ppc/code-generator-ppc.cc
index
b1fc707bca6c99b8fc02ba0323129b65670163df..75b4c1f55417e9102b30203672e1fed5f51588f3
100644
--- a/src/compiler/ppc/code-generator-ppc.cc
+++ b/src/compiler/ppc/code-generator-ppc.cc
@@ -1372,11 +1372,17 @@ void CodeGenerator::AssembleReturn() {
__ LeaveFrame(StackFrame::MANUAL);
__ Ret();
} else if (descriptor->IsJSFunctionCall() || needs_frame_) {
- int pop_count = descriptor->IsJSFunctionCall()
- ? static_cast<int>(descriptor->JSParameterCount())
- : 0;
- __ LeaveFrame(StackFrame::MANUAL, pop_count * kPointerSize);
- __ Ret();
+ // Canonicalize JSFunction return sites for now.
+ if (return_label_.is_bound()) {
+ __ b(&return_label_);
+ } else {
+ __ bind(&return_label_);
+ int pop_count = descriptor->IsJSFunctionCall()
+ ?
static_cast<int>(descriptor->JSParameterCount())
+ : 0;
+ __ LeaveFrame(StackFrame::MANUAL, pop_count * kPointerSize);
+ __ Ret();
+ }
} else {
__ Ret();
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
