http://codereview.chromium.org/545125/diff/1/10 File src/platform-solaris.cc (right):
http://codereview.chromium.org/545125/diff/1/10#newcode29 src/platform-solaris.cc:29: // parts the implementation is in platform-posix.cc. On 2010/01/21 09:58:08, Erik Corry wrote:
Please add a comment to the effect that this doesn't work on SPARC.
If you can
add a #error then that is even better, but perhaps that's hard to
test. Done. http://codereview.chromium.org/545125/diff/1/10#newcode76 src/platform-solaris.cc:76: int isgreater(double x, double y) { On 2010/01/21 09:58:08, Erik Corry wrote:
We don't seem to use this anywhere. It should be removed.
Done. http://codereview.chromium.org/545125/diff/1/10#newcode81 src/platform-solaris.cc:81: // Classify floating point number - usually defined in math.h#ifndef fpclassify On 2010/01/21 09:58:08, Erik Corry wrote:
The line above looks wrong.
Done. http://codereview.chromium.org/545125/diff/1/10#newcode125 src/platform-solaris.cc:125: // TODO: Test to see if ceil() is correct on Solaris. On 2010/01/21 09:58:08, Erik Corry wrote:
Please remove this TODO. If you suspect the unit tests are
insufficient on this
point then please file a bug in the issue database on http://code.google.com/p/v8
Done. http://codereview.chromium.org/545125/diff/1/10#newcode176 src/platform-solaris.cc:176: days = loc->tm_yday = utc->tm_yday; On 2010/01/21 09:58:08, Erik Corry wrote:
Should this '=' be a '-'?
replaced this implmentation with a simpler version http://codereview.chromium.org/545125/diff/1/10#newcode212 src/platform-solaris.cc:212: return (size_t)getpagesize(); On 2010/01/21 09:58:08, Erik Corry wrote:
We only allow C++-style casts, not C-style casts.
Done. http://codereview.chromium.org/545125/diff/1/10#newcode265 src/platform-solaris.cc:265: // Redirect to std abort to signal abnormal program termination On 2010/01/21 09:58:08, Erik Corry wrote:
Missing full stop.
Done. http://codereview.chromium.org/545125/diff/1/10#newcode311 src/platform-solaris.cc:311: UNIMPLEMENTED(); On 2010/01/21 09:58:08, Erik Corry wrote:
Please provide an empty implementation instead, so we can at least
have logging
on Solaris, even if profiling doesn't give correct results for ticks
in shared
libraries.
Done. http://codereview.chromium.org/545125/diff/1/10#newcode612 src/platform-solaris.cc:612: TickSample sample; On 2010/01/21 09:58:08, Erik Corry wrote:
Please set the sample.pc, sample.sp and sample.fp to dummy values (eg
0) and
file a bug to say that profiling doesn't work on Solaris.
Done. http://codereview.chromium.org/545125/diff/1/12 File test/cctest/test-compiler.cc (right): http://codereview.chromium.org/545125/diff/1/12#newcode77 test/cctest/test-compiler.cc:77: printf("%lc", (wint_t)string[j]); On 2010/01/21 09:58:08, Erik Corry wrote:
C-style cast.
Done. http://codereview.chromium.org/545125 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
