Reviewers: rossberg,
Message:
PTAL, I kind of dislike the crankshaft workaround but I can't see another
way
around the problem.
Description:
[strong] Implement strong mode semantics for the count operation.
Also fixes a crankshaft bug with strong implicit conversions.
It turns out that the implicit conversion of oddball values
is smushed into so many places in crankshaft that it would
have been pretty invasive surgery to make everything fall
out naturally.
BUG=v8:3956
LOG=N
Please review this at https://codereview.chromium.org/1216463003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+561, -85 lines):
M src/arm/full-codegen-arm.cc
M src/arm64/full-codegen-arm64.cc
M src/compiler/ast-graph-builder.cc
M src/hydrogen.cc
M src/hydrogen-instructions.h
M src/ia32/full-codegen-ia32.cc
M src/ic/ic-state.cc
M src/messages.h
M src/mips/full-codegen-mips.cc
M src/mips64/full-codegen-mips64.cc
M src/ppc/full-codegen-ppc.cc
M src/runtime.js
M src/runtime/runtime.h
M src/runtime/runtime-internal.cc
M src/x64/full-codegen-x64.cc
M src/x87/full-codegen-x87.cc
M test/mjsunit/strong/implicit-conversions.js
A test/mjsunit/strong/implicit-conversions-constants.js
A test/mjsunit/strong/implicit-conversions-count.js
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
