Reviewers: Sven Panne,
Description:
Meaningful name for builtins in JitCodeEvent API.
Report builtins by name (e.g. "Builtin:ArgumentsAdaptorTrampoline")
instead of labeling everything "Builtin:A builtin from the snapshot".
BUG=
Please review this at https://codereview.chromium.org/1216833002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1, -1 lines):
M src/log.cc
Index: src/log.cc
diff --git a/src/log.cc b/src/log.cc
index
c634d28e9dd572304a4b7e5901419067a7faa643..d68848b1b19d5918a458d217811ee2bab6472acd
100644
--- a/src/log.cc
+++ b/src/log.cc
@@ -1610,7 +1610,7 @@ void Logger::LogCodeObject(Object* object) {
tag = Logger::REG_EXP_TAG;
break;
case Code::BUILTIN:
- description = "A builtin from the snapshot";
+ description =
isolate_->builtins()->name(code_object->builtin_index());
tag = Logger::BUILTIN_TAG;
break;
case Code::HANDLER:
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.