Reviewers: jarin,
Description:
[turbofan] Add typing rules for the typeof operator.
[email protected]
Please review this at https://codereview.chromium.org/1218773002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+19, -1 lines):
M src/compiler/typer.cc
Index: src/compiler/typer.cc
diff --git a/src/compiler/typer.cc b/src/compiler/typer.cc
index
3a77ec311c82235384419364dbaa027990016117..5f59cea0560dbb8d69fd1389ae1575d722f8766d
100644
--- a/src/compiler/typer.cc
+++ b/src/compiler/typer.cc
@@ -331,6 +331,7 @@ class Typer::Visitor : public Reducer {
#undef DECLARE_METHOD
static Type* JSUnaryNotTyper(Type*, Typer*);
+ static Type* JSTypeOfTyper(Type*, Typer*);
static Type* JSLoadPropertyTyper(Type*, Type*, Typer*);
static Type* JSCallFunctionTyper(Type*, Typer*);
@@ -1211,8 +1212,25 @@ Bounds Typer::Visitor::TypeJSUnaryNot(Node* node) {
}
+Type* Typer::Visitor::JSTypeOfTyper(Type* type, Typer* t) {
+ Factory* const f = t->isolate()->factory();
+ if (type->Is(Type::Boolean())) {
+ return Type::Constant(f->boolean_string(), t->zone());
+ } else if (type->Is(Type::Number())) {
+ return Type::Constant(f->number_string(), t->zone());
+ } else if (type->Is(Type::Symbol())) {
+ return Type::Constant(f->symbol_string(), t->zone());
+ } else if (type->Is(Type::Union(Type::Undefined(),
Type::Undetectable()))) {
+ return Type::Constant(f->undefined_string(), t->zone());
+ } else if (type->Is(Type::Null())) {
+ return Type::Constant(f->null_string(), t->zone());
+ }
+ return Type::InternalizedString();
+}
+
+
Bounds Typer::Visitor::TypeJSTypeOf(Node* node) {
- return Bounds(Type::None(zone()), Type::InternalizedString(zone()));
+ return TypeUnaryOp(node, JSTypeOfTyper);
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
