Reviewers: tandrii(chromium), ulan,
Message:
PTAL
Description:
[android] Remove legacy architecture configs from perf runner.
The android_* configs were never real v8 target
architectures, only make targets. This doesn't make sense
with ninja anymore.
BUG=chromium:502176
LOG=n
Please review this at https://codereview.chromium.org/1220743002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+6, -16 lines):
M tools/run_perf.py
Index: tools/run_perf.py
diff --git a/tools/run_perf.py b/tools/run_perf.py
index
b09d5b5ed596fcc53d453fe239368a071595eb7b..3f73ee6c250693bd48dd978e3b4bedd5eedeac1c
100755
--- a/tools/run_perf.py
+++ b/tools/run_perf.py
@@ -108,11 +108,7 @@ from testrunner.local import commands
from testrunner.local import utils
ARCH_GUESS = utils.DefaultArch()
-SUPPORTED_ARCHS = ["android_arm",
- "android_arm64",
- "android_ia32",
- "android_x64",
- "arm",
+SUPPORTED_ARCHS = ["arm",
"ia32",
"mips",
"mipsel",
@@ -470,7 +466,7 @@ class Platform(object):
@staticmethod
def GetPlatform(options):
- if options.arch.startswith("android"):
+ if options.android_build_tools:
return AndroidPlatform(options)
else:
return DesktopPlatform(options)
@@ -632,7 +628,8 @@ def Main(args):
logging.getLogger().setLevel(logging.INFO)
parser = optparse.OptionParser()
parser.add_option("--android-build-tools",
- help="Path to chromium's build/android.")
+ help="Path to chromium's build/android. Specifying
this "
+ "option will run tests using android platform.")
parser.add_option("--arch",
help=("The architecture to run tests for, "
"'auto' or 'native' for auto-detect"),
@@ -663,15 +660,8 @@ def Main(args):
print "Unknown architecture %s" % options.arch
return 1
- if (bool(options.arch.startswith("android")) !=
- bool(options.android_build_tools)): # pragma: no cover
- print ("Android architectures imply setting --android-build-tools and
the "
- "other way around.")
- return 1
-
- if (options.device and not
- options.arch.startswith("android")): # pragma: no cover
- print "Specifying a device requires an Android architecture to be
used."
+ if (options.device and not options.android_build_tools): # pragma: no
cover
+ print "Specifying a device requires Android build tools."
return 1
workspace =
os.path.abspath(os.path.join(os.path.dirname(__file__), ".."))
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
