2010/1/22 Florian Schneider <[email protected]> > We need to add/substract a smi-tagged value here. Smi::FromInt(1) is > actually 0x2 on ia-32.
Also inc and dec are not recommended by the Intel Optimization Guide because the only partially update the flags, which interferes with the flag renaming logic. > > --Florian > > > On Fri, Jan 22, 2010 at 11:15 AM, <[email protected]> wrote: > >> >> http://codereview.chromium.org/554032/diff/5004/4014 >> File src/ia32/full-codegen-ia32.cc (right): >> >> http://codereview.chromium.org/554032/diff/5004/4014#newcode1545 >> src/ia32/full-codegen-ia32.cc:1545: __ add(Operand(eax), >> Immediate(Smi::FromInt(1))); >> just for my education: why not inc/dec? >> >> >> http://codereview.chromium.org/554032 >> > > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
