Three instances of potentially-confusing variable shadowing. Consider
fixing?
https://codereview.chromium.org/1206573004/diff/40001/src/debug.cc
File src/debug.cc (right):
https://codereview.chromium.org/1206573004/diff/40001/src/debug.cc#newcode2064
src/debug.cc:2064: SharedFunctionInfo* shared =
SharedFunctionInfo::cast(item);
Is it intentional that this shadows the outer-scope variable of the same
name? This is potentially confusing.
https://codereview.chromium.org/1206573004/diff/40001/src/debug.cc#newcode2084
src/debug.cc:2084: JSFunction* closure = NULL;
Is it intentional that this shadows the outer-scope variable of the same
name? This is potentially confusing.
https://codereview.chromium.org/1206573004/diff/40001/src/debug.cc#newcode2085
src/debug.cc:2085: SharedFunctionInfo* shared = NULL;
Is it intentional that this shadows the outer-scope variable of the same
name? This is potentially confusing.
https://codereview.chromium.org/1206573004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
