Status: New
Owner: ----
Labels: Type-Bug Priority-Medium

New issue 4257 by [email protected]: V8 build is noisy when -Wtype-limits or -Wunused-but-set-parameter
https://code.google.com/p/v8/issues/detail?id=4257

Version: b87cef133f55666d3d5ff1675c1ffdfc13956ac3
OS: Linux
Architecture: x6

What steps will reproduce the problem?
Building v8 as part of a pdfium checkout gives the following:

[167/373] CXX obj/v8/src/compiler/v8_base.simplified-lowering.o
In file included from ../../v8/src/base/build_config.h:8:0,
                 from ../../v8/src/base/macros.h:13,
                 from ../../v8/src/base/functional.h:16,
                 from ../../v8/src/compiler/node-cache.h:8,
                 from ../../v8/src/compiler/common-node-cache.h:8,
                 from ../../v8/src/compiler/js-graph.h:8,
                 from ../../v8/src/compiler/simplified-lowering.h:8,
                 from ../../v8/src/compiler/simplified-lowering.cc:5:
../../v8/src/compiler/simplified-lowering.cc: In member function ‘v8::internal::compiler::RepresentationSelector::NodeInfo* v8::internal::compiler::RepresentationSelector::GetInfo(v8::internal::compiler::Node*)’: ../../v8/src/compiler/simplified-lowering.cc:1104:21: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
     DCHECK(node->id() >= 0);
                     ^
../../v8/include/v8config.h:353:54: note: in definition of macro ‘V8_UNLIKELY’
 # define V8_UNLIKELY(condition) (__builtin_expect(!!(condition), 0))
                                                      ^
../../v8/src/base/logging.h:153:32: note: in expansion of macro ‘CHECK’
 #define DCHECK(condition)      CHECK(condition)
                                ^
../../v8/src/compiler/simplified-lowering.cc:1104:5: note: in expansion of macro ‘DCHECK’
     DCHECK(node->id() >= 0);
     ^
[265/373] CXX obj/v8/src/runtime/v8_base.runtime-atomics.o
../../v8/src/runtime/runtime-atomics.cc: In instantiation of ‘T v8::internal::{anonymous}::LoadSeqCst(T*) [with T = unsigned char]’: ../../v8/src/runtime/runtime-atomics.cc:340:76: required from ‘v8::internal::Object* v8::internal::{anonymous}::DoLoad(v8::internal::Isolate*, void*, size_t) [with T = unsigned char; size_t = long unsigned int]’
../../v8/src/runtime/runtime-atomics.cc:567:5:   required from here
../../v8/src/runtime/runtime-atomics.cc:32:10: warning: parameter ‘p’ set but not used [-Wunused-but-set-parameter]
 inline T LoadSeqCst(T* p) {
          ^
../../v8/src/runtime/runtime-atomics.cc: In instantiation of ‘T v8::internal::{anonymous}::LoadSeqCst(T*) [with T = signed char]’: ../../v8/src/runtime/runtime-atomics.cc:340:76: required from ‘v8::internal::Object* v8::internal::{anonymous}::DoLoad(v8::internal::Isolate*, void*, size_t) [with T = signed char; size_t = long unsigned int]’
../../v8/src/runtime/runtime-atomics.cc:567:5:   required from here
../../v8/src/runtime/runtime-atomics.cc:32:10: warning: parameter ‘p’ set but not used [-Wunused-but-set-parameter]
.

Should be straightforward to tidy these up. Thanks.

--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to