https://codereview.chromium.org/1216463003/diff/140001/src/compiler/ast-graph-builder.cc File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/1216463003/diff/140001/src/compiler/ast-graph-builder.cc#newcode2684 src/compiler/ast-graph-builder.cc:2684: // This should never deoptimize in sloppy mode because we have converted to s/sloppy/weak/ ? https://codereview.chromium.org/1216463003/diff/140001/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/1216463003/diff/140001/src/hydrogen.cc#newcode10326 src/hydrogen.cc:10326: if (!is_strong(function_language_mode())) { Hm, why no recording in strong mode? Can you add a comment? https://codereview.chromium.org/1216463003/diff/140001/test/mjsunit/strong/implicit-conversions-constants.js File test/mjsunit/strong/implicit-conversions-constants.js (right): https://codereview.chromium.org/1216463003/diff/140001/test/mjsunit/strong/implicit-conversions-constants.js#newcode12 test/mjsunit/strong/implicit-conversions-constants.js:12: function(x){return 1 + true;}, CAn't you generate these functions using eval? https://codereview.chromium.org/1216463003/diff/140001/test/mjsunit/strong/implicit-conversions-count.js File test/mjsunit/strong/implicit-conversions-count.js (right): https://codereview.chromium.org/1216463003/diff/140001/test/mjsunit/strong/implicit-conversions-count.js#newcode140 test/mjsunit/strong/implicit-conversions-count.js:140: //Check prior input of Smi works Nit: WS https://codereview.chromium.org/1216463003/diff/140001/test/mjsunit/strong/implicit-conversions-count.js#newcode155 test/mjsunit/strong/implicit-conversions-count.js:155: //Check prior input of Number works Nit: WS https://codereview.chromium.org/1216463003/diff/140001/test/mjsunit/strong/implicit-conversions.js File test/mjsunit/strong/implicit-conversions.js (left): https://codereview.chromium.org/1216463003/diff/140001/test/mjsunit/strong/implicit-conversions.js#oldcode64 test/mjsunit/strong/implicit-conversions.js:64: "0.79", Why did you remove these cases? https://codereview.chromium.org/1216463003/diff/140001/test/mjsunit/strong/implicit-conversions.js File test/mjsunit/strong/implicit-conversions.js (right): https://codereview.chromium.org/1216463003/diff/140001/test/mjsunit/strong/implicit-conversions.js#newcode345 test/mjsunit/strong/implicit-conversions.js:345: print(func); Stray debug output? https://codereview.chromium.org/1216463003/ -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
