http://codereview.chromium.org/546125/diff/4001/4003 File src/runtime.cc (right):
http://codereview.chromium.org/546125/diff/4001/4003#newcode7956 src/runtime.cc:7956: delete[] buffer; An alternative (and widely used in V8) approach is to make 2 passes and avoid re-allocation (or even avoid temporary array). Consider EnumerateCompiledFunctions and LogCompiledFunctions pair of functions as an example. http://codereview.chromium.org/546125/diff/4001/4003#newcode7982 src/runtime.cc:7982: if (shared->function_token_position() != RelocInfo::kNoPosition) { What if you move this logic into a method of SFI? http://codereview.chromium.org/546125 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
