Reviewers: mvstanton,
Message:
PTAL
Description:
Make context register implicit for CallInterfaceDescriptors
Up until now the context register was listed explicitly in each stub's
CallInterfaceDescriptor. This was problematic, because it was listed
first in the list of register parameters--which is fine for Crankshaft,
which is more or less built to handle the context as the first
parameter-- but not ideal for TurboFan, which adds the context at
the end of all function parameters. Now the context register is no
longer in the register list and can be handled appropriately by both
compilers. Specifically, this allows the FunctionType specified for
each CallInterfaceDescriptor to exactly match the parameter register
list.
Please review this at https://codereview.chromium.org/1211333003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+465, -471 lines):
M src/arm/code-stubs-arm.cc
M src/arm/interface-descriptors-arm.cc
M src/arm/lithium-arm.h
M src/arm/lithium-arm.cc
M src/arm64/code-stubs-arm64.cc
M src/arm64/interface-descriptors-arm64.cc
M src/arm64/lithium-arm64.h
M src/arm64/lithium-arm64.cc
M src/code-stubs.h
M src/code-stubs.cc
M src/code-stubs-hydrogen.cc
M src/compiler/linkage-impl.h
M src/deoptimizer.cc
M src/hydrogen.cc
M src/hydrogen-instructions.h
M src/ia32/code-stubs-ia32.cc
M src/ia32/interface-descriptors-ia32.cc
M src/ia32/lithium-ia32.h
M src/ia32/lithium-ia32.cc
M src/interface-descriptors.h
M src/interface-descriptors.cc
M src/mips/code-stubs-mips.cc
M src/mips/interface-descriptors-mips.cc
M src/mips/lithium-mips.h
M src/mips/lithium-mips.cc
M src/mips64/code-stubs-mips64.cc
M src/mips64/interface-descriptors-mips64.cc
M src/mips64/lithium-mips64.h
M src/mips64/lithium-mips64.cc
M src/x64/code-stubs-x64.cc
M src/x64/interface-descriptors-x64.cc
M src/x64/lithium-x64.h
M src/x64/lithium-x64.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
