Yeah, unfortunately, it won't be that simple. You will need to extend
almost all
operations in types.cc to handle the new kind of type, in order to
implement the
right algebraic properties. This will become apparent ones you extend the
Fuzz
function in types-fuzz.h to actually generate Object types -- I expect that
most
of test-types will start failing. (You may want to locally run the tests
with
increased fuzz count of 200 at types-fuzz.h:117 to converge faster with more
coverage.) Various tests also have explicit cases for some manually chosen
types, you should extend those with combinations involving the new type.
But beware, this will be quite tricky. Given that this is only for typing
one
asm parameter, I'm not sure building it deep into the type system is the
best
way forward. I'd suggest a different route: since the object is only used
in the
asm module's "imports" you should be able to recognise and handle those
syntactically directly in the asm checker.
On 2015/07/01 01:36:25, bradn wrote:
Any thoughts on naming with this?
I'm a little concerned "Object" is overused generally.
I'd be fine with Object, it is what it is.
https://codereview.chromium.org/1217803004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
