Reviewers: Yang,
Description:
Prepare profiler test for try-catch being optimizable.
This is an adaptation of test-profile-generator/BailoutReason to when
try-catch statements are optimizable. They will no longer cause any
bailout reason to be reported.
[email protected]
TEST=cctest/test-profile-generator/BailoutReason
Please review this at https://codereview.chromium.org/1213113007/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+8, -9 lines):
M test/cctest/test-profile-generator.cc
Index: test/cctest/test-profile-generator.cc
diff --git a/test/cctest/test-profile-generator.cc
b/test/cctest/test-profile-generator.cc
index
0a2c7a562576d3c25092a3c180904616683e0690..221761487c28fd84a739ce43ba3a2489fcfdd6af
100644
--- a/test/cctest/test-profile-generator.cc
+++ b/test/cctest/test-profile-generator.cc
@@ -681,14 +681,13 @@ TEST(BailoutReason) {
CHECK_EQ(0, iprofiler->GetProfilesCount());
v8::Handle<v8::Script> script =
v8::Script::Compile(v8::String::NewFromUtf8(env->GetIsolate(),
- "function TryCatch() {\n"
- " try {\n"
- " startProfiling();\n"
- " } catch (e) { };\n"
+ "function Debugger() {\n"
+ " debugger;\n"
+ " startProfiling();\n"
"}\n"
"function TryFinally()
{\n"
" try {\n"
- " TryCatch();\n"
+ " Debugger();\n"
" } finally { };\n"
"}\n"
"TryFinally();\n"
@@ -703,8 +702,8 @@ TEST(BailoutReason) {
// The tree should look like this:
// (root)
// ""
- // kTryFinally
- // kTryCatch
+ // kTryFinallyStatement
+ // kDebuggerStatement
current = PickChild(current, "");
CHECK(const_cast<v8::CpuProfileNode*>(current));
@@ -712,7 +711,7 @@ TEST(BailoutReason) {
CHECK(const_cast<v8::CpuProfileNode*>(current));
CHECK(!strcmp("TryFinallyStatement", current->GetBailoutReason()));
- current = PickChild(current, "TryCatch");
+ current = PickChild(current, "Debugger");
CHECK(const_cast<v8::CpuProfileNode*>(current));
- CHECK(!strcmp("TryCatchStatement", current->GetBailoutReason()));
+ CHECK(!strcmp("DebuggerStatement", current->GetBailoutReason()));
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
