looking good, just naming nits
https://codereview.chromium.org/1217813012/diff/20001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1217813012/diff/20001/src/heap/heap.cc#newcode2641
src/heap/heap.cc:2641: bool hope_high_promotion_problem_will_fix_itself
=
funny name :) but can we please have a shorter version.
still_gathering_lifetime_data? or something?
https://codereview.chromium.org/1217813012/diff/20001/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1217813012/diff/20001/src/heap/heap.h#newcode1378
src/heap/heap.h:1378:
recently_deopted_code_that_will_be_reopted_with_pretenuring_ = 2;
it is not clear if the code will be tenured. you could call it:
gather_lifetime_feedback
https://codereview.chromium.org/1217813012/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
